Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Improvements #3075

Merged
merged 7 commits into from Jul 24, 2017
Merged

rsx: Improvements #3075

merged 7 commits into from Jul 24, 2017

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jul 23, 2017

Minor tweaks for performance and improved stability

  • Fix buffer overrun crash (LBP Karting, Ridge Racer 7)
  • Fix opengl bug when initializing framebuffers (Removes the 'fbo check failed' spam)
  • Vulkan: improvements to multithreaded vertex processing
  • Vulkan: volatile vertex cache implemented to help performance in geometry heavy scenes
  • Vulkan: pre-emptive framebuffer flushing to lower the penalty of a cache miss

@mention-bot
Copy link

@kd-11, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vlj, @Nekotekina and @jarveson to be potential reviewers.

@zminhquanz
Copy link

Will it improve on Demon's Souls and Persona 5 , etc ?

@Luffykun007
Copy link

I know is that fixed the freeze error in Virtua Fighter V - Final showdown thanks @ KD-11

@AniLeo
Copy link
Member

AniLeo commented Jul 24, 2017

If you read the latest announcement you'll know this fixes DeS crashes

@YaPeL
Copy link

YaPeL commented Jul 24, 2017

pretty sure thats already on master @AniLeo and not related to this PR

@AniLeo
Copy link
Member

AniLeo commented Jul 24, 2017

Yeah, the important commit was already merged, but this is also needed. There's an issue with OpenGL crashing that should be fixed by this PR. If not, then kd is still investigating

@SakataGintokiYT
Copy link
Contributor

SakataGintokiYT commented Jul 24, 2017

@kd-11

Can you try fix this error ?

Dead Space™ 2 Demo / Yakuza 3 with GCM
[Vulkan]

F {rsx::thread} class std::runtime_error thrown: Working buffer not big enough, buffer_length=268435456 allocated=268121088 requested=402152 guard=65536 largest_pool=804864
(in file c:\rpcs3\rpcs3\emu\rsx\d3d12\../Common/ring_buffer_helper.h:74)

Log:

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 24, 2017

Just increase the guard size if you are building from source. It should be configurable

@Xcedf
Copy link

Xcedf commented Jul 24, 2017

@kd-11 what need to be changed to increase it?

@bjakja
Copy link

bjakja commented Jul 24, 2017

Is it this place?
"void init(size_t heap_size, size_t min_guard_size=0x10000)"
Guard size is the same with this from error.

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 24, 2017

Yes, just bump it up to something like 1MB (add another 0)

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 24, 2017

Some few games are not playing nice with the vertex cache but I'm merging this as is for now instead of relegating to WIP as it may keep the advancements in limbo for a long time.

@kd-11 kd-11 merged commit 3b03f9a into RPCS3:master Jul 24, 2017
@zminhquanz
Copy link

@kd-11 wow , good job for you , Demon's Souls now is stable frame per second a lot

@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Jul 24, 2017

have broken Uncharted and tlou loading screen with vulkan, now show only black screen, caused by commit a7f95eb and with change in file VKVertexBuffers.cpp

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 24, 2017

Its not a simple fixable thing - it requires a different type of vertex cache. I'm working on it
An option to disable the cache will be made available soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants